Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1616612

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Show all headers | View raw

On 04/04/2017 08:56 PM, Dmitry Monakhov wrote:
> bio_integrity_trim inherent it's interface from bio_trim and accept
> offset and size, but this API is error prone because data offset
> must always be insync with bio's data offset. That is why we have
> integrity update hook in bio_advance()
> 
> So only meaningful values are: offset == 0, sectors == bio_sectors(bio)
> Let's just remove them completely.
> 
> changes from v1:
>  - remove 'sectors' arguments
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
>  block/bio-integrity.c | 11 ++---------
>  block/bio.c           |  4 ++--
>  drivers/md/dm.c       |  2 +-
>  include/linux/bio.h   |  5 ++---
>  4 files changed, 7 insertions(+), 15 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] block: T10/DIF Fixes and cleanups v3 Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
  [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2 Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
    Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim  v2 Hannes Reinecke <hare@suse.de> - 2017-04-05 08:40 +0200
    Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim  v2 Christoph Hellwig <hch@infradead.org> - 2017-04-06 13:40 +0200
  [PATCH 8/9] bio: add bvec_iter rewind API Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
    Re: [PATCH 8/9] bio: add bvec_iter rewind API Christoph Hellwig <hch@infradead.org> - 2017-04-06 13:50 +0200
  [PATCH 2/9] bio-integrity: bio_trim should truncate integrity vector accordingly Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
    Re: [PATCH 2/9] bio-integrity: bio_trim should truncate integrity  vector accordingly Hannes Reinecke <hare@suse.de> - 2017-04-05 08:40 +0200
  [PATCH 6/9] T10: Move opencoded contants to common header Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
    Re: [PATCH 6/9] T10: Move opencoded contants to common header Hannes Reinecke <hare@suse.de> - 2017-04-05 08:40 +0200
    Re: [PATCH 6/9] T10: Move opencoded contants to common header Christoph Hellwig <hch@infradead.org> - 2017-04-06 13:50 +0200
  [PATCH 1/9] bio-integrity: Do not allocate integrity context for bio w/o data Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
  [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to bio_integrity_prep Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
    Re: [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to  bio_integrity_prep Hannes Reinecke <hare@suse.de> - 2017-04-05 08:40 +0200
    Re: [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to  bio_integrity_prep Christoph Hellwig <hch@infradead.org> - 2017-04-06 13:50 +0200
  [PATCH 9/9] bio-integrity: Restore original iterator on verify stage Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
    Re: [PATCH 9/9] bio-integrity: Restore original iterator on verify  stage Christoph Hellwig <hch@infradead.org> - 2017-04-06 13:50 +0200
  [PATCH 3/9] bio-integrity:  bio_integrity_advance must update integrity seed Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-04 21:00 +0200
    Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update  integrity seed Hannes Reinecke <hare@suse.de> - 2017-04-05 08:40 +0200
    Re: [PATCH 3/9] bio-integrity:  bio_integrity_advance must update  integrity seed Christoph Hellwig <hch@infradead.org> - 2017-04-06 13:40 +0200

csiph-web