Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614339

Re: [PATCH] [media] vcodec: mediatek: Remove double parentheses

Show all headers | View raw

El Fri, Mar 17, 2017 at 02:01:33PM -0700 Matthias Kaehlcke ha dit:

> The extra pairs of parentheses are not needed and cause clang
> warnings like this:
> 
> drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
>                 if ((inst->work_bufs[i].size == 0))
>                      ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: note: remove extraneous parentheses around the comparison to silence this warning
>                 if ((inst->work_bufs[i].size == 0))
>                     ~                        ^   ~
> drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: note: use '=' to turn this equality comparison into an assignment
>                 if ((inst->work_bufs[i].size == 0))
>                                              ^~
>                                              =
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c
> index 544f57186243..129cc74b4fe4 100644
> --- a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c
> +++ b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c
> @@ -155,7 +155,7 @@ static void vp8_enc_free_work_buf(struct venc_vp8_inst *inst)
>  
>  	/* Buffers need to be freed by AP. */
>  	for (i = 0; i < VENC_VP8_VPU_WORK_BUF_MAX; i++) {
> -		if ((inst->work_bufs[i].size == 0))
> +		if (inst->work_bufs[i].size == 0)
>  			continue;
>  		mtk_vcodec_mem_free(inst->ctx, &inst->work_bufs[i]);
>  	}
> @@ -172,7 +172,7 @@ static int vp8_enc_alloc_work_buf(struct venc_vp8_inst *inst)
>  	mtk_vcodec_debug_enter(inst);
>  
>  	for (i = 0; i < VENC_VP8_VPU_WORK_BUF_MAX; i++) {
> -		if ((wb[i].size == 0))
> +		if (wb[i].size == 0)
>  			continue;
>  		/*
>  		 * This 'wb' structure is set by VPU side and shared to AP for

Ping? Any feedback on this patch?

Cheers

Matthias

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] [media] vcodec: mediatek: Remove double parentheses Matthias Kaehlcke <mka@chromium.org> - 2017-04-01 02:00 +0200
  Re: [PATCH] [media] vcodec: mediatek: Remove double parentheses Hans Verkuil <hverkuil@xs4all.nl> - 2017-04-03 10:40 +0200

csiph-web