Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614766

Re: [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Daniel Vetter <daniel@ffwll.ch> writes:

> I think it'd be good if we could consolidate all the lease checking into
> drm_mode_object_find (respectively __drm_mode_object_find). We'd need to
> wire up the fpriv to be able to do that, but we could upstream that patch
> right away before anything else. That should take care of most of the
> checks in this patch here.

That's a good idea.

> There's a few things on top:
> - filtering the various bitmasks. I think you have most, but we could
>   perhaps upstream the helpers for these.

Yeah, would be nice to get hooks in place soon to avoid rebase
adventures later. I guess that would involve shipping a stub drm_lease.h
for now?

> - filtering object lists (essentially getresources and getplanes ioctls).
> - filtering implicit objects in the legacy ioctl. E.g. page_flip done
>   through atomic doesn't just need the CRTC id, but also the id of the
>   primary plane plus of the FB_ID atomic property. Similarly for all the
>   other legacy ioctls. I think we want to make sure there's no difference
>   here in behaviour.

Oh, all of the implicit resource access from the legacy ioctls. Yeah,
that will take a bit of research to identify all of them.

> Especially for the last one it might be simplest to outright disallow all
> legacy ioctl and require that sub-drm_master nodes only get access to the
> read-only GET* ioctl (they get that anyway, even when they're not the
> current master), plus atomic. Makes it a _lot_ easier to implement.
> Downside is that amdgpu _really_ needs to land atomic asap :-)

I'd like to avoid that particular dependency as amdgpu is something of a
requirement for this particular project...

I'll get started fixing the lease checking stuff to try and centralize it.

-- 
-keith

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] drm: Add mode resource leasing Keith Packard <keithp@keithp.com> - 2017-04-01 19:20 +0200
  [PATCH 1/4] drm: Add new LEASE debug level Keith Packard <keithp@keithp.com> - 2017-04-01 19:20 +0200
  [PATCH 2/4] drm: Add drm_object lease infrastructure Keith Packard <keithp@keithp.com> - 2017-04-01 19:20 +0200
    Re: [PATCH 2/4] drm: Add drm_object lease infrastructure Daniel Vetter <daniel@ffwll.ch> - 2017-04-02 15:40 +0200
      Re: [PATCH 2/4] drm: Add drm_object lease infrastructure Keith Packard <keithp@keithp.com> - 2017-04-02 18:40 +0200
        Re: [PATCH 2/4] drm: Add drm_object lease infrastructure Michel Dänzer <michel@daenzer.net> - 2017-04-10 07:20 +0200
    Re: [PATCH 2/4] drm: Add drm_object lease infrastructure Daniel Vetter <daniel@ffwll.ch> - 2017-04-02 20:00 +0200
      Re: [PATCH 2/4] drm: Add drm_object lease infrastructure Keith Packard <keithp@keithp.com> - 2017-04-02 22:10 +0200
  [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths Keith Packard <keithp@keithp.com> - 2017-04-01 19:20 +0200
    Re: [PATCH 3/4] drm: Check mode object lease status in all master  ioctl paths Daniel Vetter <daniel@ffwll.ch> - 2017-04-02 15:20 +0200
      Re: [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths Keith Packard <keithp@keithp.com> - 2017-04-02 18:40 +0200
        Re: [PATCH 3/4] drm: Check mode object lease status in all master  ioctl paths Daniel Vetter <daniel@ffwll.ch> - 2017-04-03 10:00 +0200
      Re: [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths Keith Packard <keithp@keithp.com> - 2017-04-10 06:50 +0200

csiph-web