Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614696

Re: [PATCH] staging:iio:accel:adis16029 fixed checkpatch issue - drop braces around single if statement

Show all headers | View raw

See patch title. Check the part number...

On 29/03/17 09:36, Andrea della Porta wrote:
> Fixed the followinf checkpatch warning:
> WARNING: braces {} are not necessary for single statement blocks
> #258: FILE: drivers/staging/iio/accel/adis16209.c:258:
> +		if (ret) {
> +			return ret;
> +		}
> 
> Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
Was fixed about a week ago by Mark Stenglein.

Patch has made it through the IIO tree to staging yet though.
Should be heading that way this afternoon (depending on how
long Greg's backlog of emails still is ;)

Jonathan
> ---
>  drivers/staging/iio/accel/adis16209.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index 52fa2e0..159a687 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
>  		}
>  		addr = adis16209_addresses[chan->scan_index][0];
>  		ret = adis_read_reg_16(st, addr, &val16);
> -		if (ret) {
> +		if (ret)
>  			return ret;
> -		}
> +
>  		val16 &= (1 << bits) - 1;
>  		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
>  		*val = val16;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging:iio:accel:adis16029 fixed checkpatch issue - drop  braces around single if statement Andrea della Porta <sfaragnaus@gmail.com> - 2017-03-30 04:10 +0200
  Re: [PATCH] staging:iio:accel:adis16029 fixed checkpatch issue - drop  braces around single if statement Jonathan Cameron <jic23@kernel.org> - 2017-04-02 12:40 +0200

csiph-web