Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1614181

[PATCH 3/8] statx: remove incorrect part of vfs_statx() comment

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject [PATCH 3/8] statx: remove incorrect part of vfs_statx() comment
Date 2017-03-31 19:40 +0200
Message-ID <tr8GJ-7Fk-1@gated-at.bofh.it> (permalink)
References <tr8GJ-7Fk-3@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


From: Eric Biggers <ebiggers@google.com>

request_mask and query_flags are function arguments, not passed in
struct kstat.  So remove the part of the comment which claims otherwise.
This was apparently left over from an earlier version of the statx
patch.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

 fs/stat.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/stat.c b/fs/stat.c
index df484a60846d..b792dd201c31 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -159,9 +159,6 @@ EXPORT_SYMBOL(vfs_statx_fd);
  * Additionally, the use of AT_SYMLINK_NOFOLLOW in flags will prevent a symlink
  * at the given name from being referenced.
  *
- * The caller must have preset stat->request_mask as for vfs_getattr().  The
- * flags are also used to load up stat->query_flags.
- *
  * 0 will be returned on success, and a -ve error code if unsuccessful.
  */
 int vfs_statx(int dfd, const char __user *filename, int flags,

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 3/8] statx: remove incorrect part of vfs_statx() comment David Howells <dhowells@redhat.com> - 2017-03-31 19:40 +0200

csiph-web