Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614139

Re: [PATCH net-next v2 2/9] net: dsa: mv88e6xxx: use 4-bit port for PVT data

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net-next v2 2/9] net: dsa: mv88e6xxx: use 4-bit port for PVT data
Date 2017-03-31 18:40 +0200
Message-ID <tr7KF-714-5@gated-at.bofh.it> (permalink)
References <tqQ77-42d-9@gated-at.bofh.it> <tqQ78-42d-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> +/* Offset 0x1D: Misc Register */
> +
> +static int mv88e6xxx_g2_misc_5_bit_port(struct mv88e6xxx_chip *chip,
> +					bool port_5_bit)
> +{
> +	u16 val;
> +	int err;
> +
> +	err = mv88e6xxx_g2_read(chip, GLOBAL2_MISC, &val);
> +	if (err)
> +		return err;
> +
> +	if (port_5_bit)
> +		val |= GLOBAL2_MISC_5_BIT_PORT;
> +	else
> +		val &= ~GLOBAL2_MISC_5_BIT_PORT;
> +
> +	return mv88e6xxx_g2_write(chip, GLOBAL2_MISC, val);
> +}
> +
> +int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip)
> +{
> +	return mv88e6xxx_g2_misc_5_bit_port(chip, false);
> +}

Hi Vivien

Yes, i know, i'm nit-picking. The function naming is confusing here.
What would you call this function:

int mv88e6xxx_g2_misc_XXXXX(struct mv88e6xxx_chip *chip)
{
	return mv88e6xxx_g2_misc_5_bit_port(chip, true);
}

Thanks
	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 0/9] net: dsa: mv88e6xxx: program cross-chip bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-30 23:50 +0200
  [PATCH net-next v2 2/9] net: dsa: mv88e6xxx: use 4-bit port for PVT data Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-30 23:50 +0200
    Re: [PATCH net-next v2 2/9] net: dsa: mv88e6xxx: use 4-bit port for  PVT data Andrew Lunn <andrew@lunn.ch> - 2017-03-31 18:40 +0200
  [PATCH net-next v2 9/9] net: dsa: mv88e6xxx: add cross-chip bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-30 23:50 +0200
    Re: [PATCH net-next v2 9/9] net: dsa: mv88e6xxx: add cross-chip  bridging Andrew Lunn <andrew@lunn.ch> - 2017-03-31 18:50 +0200
      Re: [PATCH net-next v2 9/9] net: dsa: mv88e6xxx: add cross-chip bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-31 19:00 +0200
        Re: [PATCH net-next v2 9/9] net: dsa: mv88e6xxx: add cross-chip  bridging Andrew Lunn <andrew@lunn.ch> - 2017-03-31 19:20 +0200
          Re: [PATCH net-next v2 9/9] net: dsa: mv88e6xxx: add cross-chip bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-31 19:30 +0200
  [PATCH net-next v2 5/9] net: dsa: mv88e6xxx: rework in-chip bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-30 23:50 +0200
  [PATCH net-next v2 6/9] net: dsa: mv88e6xxx: factorize in-chip bridge map Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-30 23:50 +0200
  [PATCH net-next v2 8/9] net: dsa: add cross-chip bridging operations Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-30 23:50 +0200
  Re: [PATCH net-next v2 0/9] net: dsa: mv88e6xxx: program  cross-chip bridging David Miller <davem@davemloft.net> - 2017-04-01 21:30 +0200

csiph-web