Re: [PATCH 6/8] platform/x86: fujitsu-laptop: use a sparse keymap for hotkey event generation

From	Michał Kępień <kernel@kempniu.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/8] platform/x86: fujitsu-laptop: use a sparse keymap for hotkey event generation
Date	2017-03-31 13:30 +0200
Message-ID	<tr2UG-3Xe-35@gated-at.bofh.it> (permalink)
References	<tn4V3-4Nu-5@gated-at.bofh.it> <tn4V3-4Nu-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> @@ -1098,14 +1075,8 @@ static void acpi_fujitsu_laptop_notify(struct acpi_device *device, u32 event)
>  	 * handled in software; its state is queried using FUNC_FLAGS
>  	 */
>  	if ((fujitsu_laptop->flags_supported & BIT(26)) &&
> -	    (call_fext_func(FUNC_FLAGS, 0x1, 0x0, 0x0) & BIT(26))) {
> -		keycode = KEY_TOUCHPAD_TOGGLE;
> -		input_report_key(input, keycode, 1);
> -		input_sync(input);
> -		input_report_key(input, keycode, 0);
> -		input_sync(input);
> -	}
> -
> +	    (call_fext_func(FLAG_RFKILL, 0x1, 0x0, 0x0) & BIT(26)))
> +		sparse_keymap_report_event(input, BIT(26), 1, true);

I have only just now noticed that a typo crept in here, causing a bug.
The original call to call_fext_func() passed FUNC_FLAGS as the first
argument while the added one uses FLAG_RFKILL instead.  This is wrong as
call_fext_func() arguments should be left intact by this patch.

Darren, could you please amend this in testing?  The call_fext_func()
call added by the above patch chunk should pass FUNC_FLAGS as the first
argument, not FLAG_RFKILL.

Thanks and sorry for the trouble.

-- 
Best regards,
Michał Kępień

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 6/8] platform/x86: fujitsu-laptop: use a sparse keymap  for hotkey event generation Michał Kępień <kernel@kempniu.pl> - 2017-03-31 13:30 +0200
  Re: [PATCH 6/8] platform/x86: fujitsu-laptop: use a sparse keymap  for hotkey event generation Darren Hart <dvhart@infradead.org> - 2017-04-01 22:10 +0200
    Re: [PATCH 6/8] platform/x86: fujitsu-laptop: use a sparse keymap  for hotkey event generation Jonathan Woithe <jwoithe@just42.net> - 2017-04-02 11:10 +0200

csiph-web