Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1612351

Re: [PATCH] iio: adc: ad799x: constify attribute_group structures

Show all headers | View raw

On 28/03/17 21:07, simran singhal wrote:
> Check for attribute_group structures that are only stored in the
> event_attrs filed of iio_info structure. As the event_attrs field of
> iio_info structures is constant, so these attribute_group structures can
> also be declared constant.
> Done using coccinelle:
> 
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct attribute_group i@p = {...};
> 
> @ok1@
> identifier r1.i;
> position p;
> struct iio_info x;
> @@
> x.event_attrs=&i@p;
> 
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct attribute_group i={...};
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct attribute_group i;
> 
> File size before:
>    text    data     bss     dec     hex filename
>   26051     464       0   26515    6793 drivers/iio/adc/ad799x.o
> 
> File size after:
>    text	   data	    bss	    dec	    hex	filename
>   26115	    400	      0	  26515	   6793	drivers/iio/adc/ad799x.o
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/ad799x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
> index 9704090..22426ae 100644
> --- a/drivers/iio/adc/ad799x.c
> +++ b/drivers/iio/adc/ad799x.c
> @@ -520,7 +520,7 @@ static struct attribute *ad799x_event_attributes[] = {
>  	NULL,
>  };
>  
> -static struct attribute_group ad799x_event_attrs_group = {
> +static const struct attribute_group ad799x_event_attrs_group = {
>  	.attrs = ad799x_event_attributes,
>  };
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: adc: ad799x: constify attribute_group structures simran singhal <singhalsimran0@gmail.com> - 2017-03-28 22:10 +0200
  Re: [PATCH] iio: adc: ad799x: constify attribute_group structures Jonathan Cameron <jic23@kernel.org> - 2017-03-29 23:20 +0200
    Re: [PATCH] iio: adc: ad799x: constify attribute_group structures Jonathan Cameron <jic23@kernel.org> - 2017-03-29 23:40 +0200
      Re: [PATCH] iio: adc: ad799x: constify attribute_group structures SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-29 23:50 +0200
    Re: [PATCH] iio: adc: ad799x: constify attribute_group structures SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-29 23:40 +0200

csiph-web