Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok
Date	2017-03-30 09:10 +0200
Message-ID	<tqCnv-2DB-1@gated-at.bofh.it> (permalink)
References	<tqoXf-188-5@gated-at.bofh.it> <tqoXf-188-11@gated-at.bofh.it> <tqsoa-3FE-17@gated-at.bofh.it> <tqt0S-4cP-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Andy Lutomirski <luto@amacapital.net> wrote:

> On Wed, Mar 29, 2017 at 1:20 PM, Borislav Petkov <bp@alien8.de> wrote:
> > On Wed, Mar 29, 2017 at 09:48:41AM -0700, Andy Lutomirski wrote:
> >> Linux refuses to boot if WP doesn't work okay, so tracking whether
> >> it works serves no purpose.  The only use I can see at all for wp_works_ok
> >> is that it lets Xen bypass test_wp_bit().  If this is truly needed,
> >> it could be more cleanly handled using X86_FEATURE_XENPV, but it
> >> looks like Xen can handle test_wp_bit() correctly without special
> >> cases at all.
> >>
> >> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=6415813bae75feba10b8ca3ed6634a72c2a4d313
> >
> > What's up?
> >
> 
> Wow, I based on tip/x86/mm per Ingo's request, but maybe that was the
> wrong branch, and apparently Mathias did the same thing in the mean
> time.  Whoops.  I'll rebase again.

Oops, I didn't realize the duplication either. The splitting up of the patch that 
I requested made the merge easier I suspect - albeit that's an unintended side 
effect.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok Andy Lutomirski <luto@kernel.org> - 2017-03-29 18:50 +0200
  Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok Borislav Petkov <bp@alien8.de> - 2017-03-29 22:30 +0200
    Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok Andy Lutomirski <luto@amacapital.net> - 2017-03-29 23:10 +0200
      Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok Ingo Molnar <mingo@kernel.org> - 2017-03-30 09:10 +0200

csiph-web