Re: [PATCH] mm,hugetlb: compute page_size_log properly

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm,hugetlb: compute page_size_log properly
Date	2017-03-30 08:20 +0200
Message-ID	<tqBB7-23k-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <tq2Dn-22K-7@gated-at.bofh.it> <tq2Dn-22K-9@gated-at.bofh.it> <tq3zr-2Gq-11@gated-at.bofh.it> <tqgQ2-46p-1@gated-at.bofh.it> <tqpTj-1P5-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 29-03-17 10:45:14, Andi Kleen wrote:
> On Wed, Mar 29, 2017 at 10:06:25AM +0200, Michal Hocko wrote:
> > On Tue 28-03-17 10:54:08, Matthew Wilcox wrote:
> > > On Tue, Mar 28, 2017 at 09:55:13AM -0700, Davidlohr Bueso wrote:
> > > > Do we have any consensus here? Keeping SHM_HUGE_* is currently
> > > > winning 2-1. If there are in fact users out there computing the
> > > > value manually, then I am ok with keeping it and properly exporting
> > > > it. Michal?
> > > 
> > > Well, let's see what it looks like to do that.  I went down the rabbit
> > > hole trying to understand why some of the SHM_ flags had the same value
> > > as each other until I realised some of them were internal flags, some
> > > were flags to shmat() and others were flags to shmget().  Hopefully I
> > > disambiguated them nicely in this patch.  I also added 8MB and 16GB sizes.
> > > Any more architectures with a pet favourite huge/giant page size we
> > > should add convenience defines for?
> > 
> > Do we actually have any users?
> 
> Yes this feature is widely used.

Considering that none of SHM_HUGE* has been exported to the userspace
headers all the users would have to use the this flag by the value and I
am quite skeptical that application actually do that. Could you point me
to some projects that use this?
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm,hugetlb: compute page_size_log properly Davidlohr Bueso <dave@stgolabs.net> - 2017-03-28 19:00 +0200
  Re: [PATCH] mm,hugetlb: compute page_size_log properly Davidlohr Bueso <dave@stgolabs.net> - 2017-03-28 19:00 +0200
    Re: [PATCH] mm,hugetlb: compute page_size_log properly Matthew Wilcox <willy@infradead.org> - 2017-03-28 20:00 +0200
      Re: [PATCH] mm,hugetlb: compute page_size_log properly Michal Hocko <mhocko@kernel.org> - 2017-03-29 10:10 +0200
        Re: [PATCH] mm,hugetlb: compute page_size_log properly Andi Kleen <ak@linux.intel.com> - 2017-03-29 19:50 +0200
          Re: [PATCH] mm,hugetlb: compute page_size_log properly Michal Hocko <mhocko@kernel.org> - 2017-03-30 08:20 +0200

csiph-web