Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations
Date	2017-03-28 12:20 +0200
Message-ID	<tpWoh-65Z-5@gated-at.bofh.it> (permalink)
References	(5 earlier) <towPg-1DH-11@gated-at.bofh.it> <tpUcN-4ow-1@gated-at.bofh.it> <tpVBU-5sY-25@gated-at.bofh.it> <tpW4W-5IO-11@gated-at.bofh.it> <tpW4W-5IO-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Dmitry Vyukov <dvyukov@google.com> wrote:

> > So I'm not convinced that it's true in this case.
> >
> > Could we see the C version and compare? I could be wrong about it all.
> 
> Here it is (without instrumentation):
> https://gist.github.com/dvyukov/e33d580f701019e0cd99429054ff1f9a

Could you please include the full patch so that it can be discussed via email and 
such?

> Instrumentation will add for each function:
> 
>  static __always_inline void atomic64_set(atomic64_t *v, long long i)
>  {
> +       kasan_check_write(v, sizeof(*v));
>         arch_atomic64_set(v, i);
>  }

That in itself looks sensible and readable.

Thanks,

	Ingo

Thread

Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations Ingo Molnar <mingo@kernel.org> - 2017-03-28 10:00 +0200
  Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations Peter Zijlstra <peterz@infradead.org> - 2017-03-28 11:30 +0200
    Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations Dmitry Vyukov <dvyukov@google.com> - 2017-03-28 11:50 +0200
    Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations Dmitry Vyukov <dvyukov@google.com> - 2017-03-28 12:00 +0200
      Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations Ingo Molnar <mingo@kernel.org> - 2017-03-28 12:20 +0200
        Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations Dmitry Vyukov <dvyukov@google.com> - 2017-03-28 18:40 +0200
    Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations Ingo Molnar <mingo@kernel.org> - 2017-03-28 12:00 +0200

csiph-web