Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands
Date	2017-03-28 12:10 +0200
Message-ID	<tpWeD-62o-41@gated-at.bofh.it> (permalink)
References	(6 earlier) <tov6O-la-17@gated-at.bofh.it> <tprNv-bf-1@gated-at.bofh.it> <tpUPx-4W7-21@gated-at.bofh.it> <tpVix-5md-7@gated-at.bofh.it> <tpW4W-5IO-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[...]

>> The retry mechanism provided by mmc_wait_for_cmd() and friends really only
>> makes sense for simple commands.  In other cases, like this, we need to
>> consider what state the card is in.  For __mmc_switch we need to consider
>> whether the card is busy or whether a timing change been made.
>
> I definitely agree. We should remove retries for CMD6 and perhaps also
> for some other cases.
>
> When we have changed the above in __mmc_switch(), the change Chaotian
> suggest gets a different impact, as it would potentially allow a
> re-tuning to happen before the next CMD1to poll for busy or to check

/s/CMD1/CMD13

> the switch status. This isn't okay.
>
> This all sounds to me that Chaotian's issue may not all be related to
> tuning, but to the CMD6 switch sequence itself. However I may be wrong
> - of course. :-)
>
> [...]
>
> Kind regards
> Uffe

Thread

Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-28 10:40 +0200
  Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Adrian Hunter <adrian.hunter@intel.com> - 2017-03-28 11:10 +0200
    Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-28 12:00 +0200
      Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-28 12:10 +0200
        Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-29 04:30 +0200
    Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-28 12:10 +0200
  Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-29 12:40 +0200
    Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-29 12:40 +0200

csiph-web