Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node

From	Shawn Guo <shawnguo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node
Date	2017-03-24 14:20 +0100
Message-ID	<toxih-239-3@gated-at.bofh.it> (permalink)
References	<tnSI9-6gL-3@gated-at.bofh.it> <tnSI9-6gL-7@gated-at.bofh.it> <topXs-59y-13@gated-at.bofh.it> <tosVk-7gO-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 24, 2017 at 02:02:38PM +0530, Jagan Teki wrote:
> On Fri, Mar 24, 2017 at 10:53 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Wed, Mar 22, 2017 at 11:18:12PM +0530, Jagan Teki wrote:
> >> From: Jagan Teki <jagan@amarulasolutions.com>
> >>
> >> Add support for Sound card and related codec(via i2c1) nodes
> >> on Engicam Is.IoT MX6UL variant module boards.
> >>
> >> Cc: Shawn Guo <shawnguo@kernel.org>
> >> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> >> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >> ---
> >>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 11 +++++++++++
> >>  arch/arm/boot/dts/imx6ul-isiot.dtsi        | 30 ++++++++++++++++++++++++++++++
> >>  2 files changed, 41 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> index b149b5e..c79fa42 100644
> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> @@ -41,6 +41,17 @@
> >>   */
> >>
> >>  &i2c1 {
> >> +     codec: sgtl5000@0a {
> >
> >         sgtl5000: codec@a {
> 
> Just to understand, why codec: sgtl5000@0a not a suitable notation?
> couldn't see any Documentation.

The node name should be generic.  Please see ePAPR '2.2.2 Generic Names
Recommendation'.  Also, the unit-address shouldn't have leading zeros.

Shawn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node Jagan Teki <jagan@openedev.com> - 2017-03-22 19:00 +0100
  Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec  node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 06:30 +0100
    Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node Jagan Teki <jagan@amarulasolutions.com> - 2017-03-24 09:40 +0100
      Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec  node Shawn Guo <shawnguo@kernel.org> - 2017-03-24 14:20 +0100

csiph-web