Re: [PATCH] mm: fix a coding style issue

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: fix a coding style issue
Date	2017-03-24 08:30 +0100
Message-ID	<torPz-6yo-5@gated-at.bofh.it> (permalink)
References	<to5P3-7B0-9@gated-at.bofh.it> <to68p-7Yi-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 23-03-17 10:12:44, Kristaps Civkulis wrote:
> Fix a coding style issue.

I believe style fixes are worth applying only when part of a larger
change which does something useful or where the resulting code is much
easier to read. This doesn't seem to be the case here.
 
> Signed-off-by: Kristaps Civkulis <kristaps.civkulis@gmail.com>
> ---
> Resend, because it should be only [PATCH] in subject.
> ---
>  mm/hugetlb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 3d0aab9ee80d..4c72c1974c8c 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h,
>  			return 0;
>  		else
>  			return 1;
> -	}
> -	else
> +	} else
>  		return ret < 0 ? ret : 0;
>  }
> 
> -- 
> 2.12.0
> 

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] mm: fix a coding style issue Kristaps Civkulis <kristaps.civkulis@gmail.com> - 2017-03-23 09:00 +0100
  [PATCH] mm: fix a coding style issue Kristaps Civkulis <kristaps.civkulis@gmail.com> - 2017-03-23 09:20 +0100
    Re: [PATCH] mm: fix a coding style issue Michal Hocko <mhocko@kernel.org> - 2017-03-24 08:30 +0100

csiph-web