Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen

From	Stanislaw Gruszka <sgruszka@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen
Date	2017-03-23 14:20 +0100
Message-ID	<toaOJ-2Hz-1@gated-at.bofh.it> (permalink)
References	<tnB4B-1Kf-9@gated-at.bofh.it> <tnCtI-2B5-3@gated-at.bofh.it> <tnKrg-8tF-25@gated-at.bofh.it> <tnSIa-6gL-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 22, 2017 at 10:56:02AM -0700, Ankur Arora wrote:
> >It is ok to do upload_pm_data() with delay i.e. after some other
> >resume actions are done and possibly xen-acpi-processor is in
> >running state ?
> The state uploaded is ACPI P and C state from struct acpi_processor
> which AFAICS is stable once inited so a delay would not lead to
> invalid state.
> The only concern would be the ACPI pCPU hotplug logic in
> acpi_processor_add() which could add a new entry in
> per_cpu(processors) but that also looks okay because either we
> get a NULL or we get a pointer to an inited structure.
> 
> As for the hypervisor -- that falls back to more limited state after
> resume (because some of this state is thrown away at suspend) and so
> uses that until it gets the uploaded PM state from the initial-domain.

Patch looks good to me then.

Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>

Thread

[PATCH 0/2 v2] xen/acpi: upload PM state from init-domain to Xen Ankur Arora <ankur.a.arora@oracle.com> - 2017-03-22 00:40 +0100
  [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen Ankur Arora <ankur.a.arora@oracle.com> - 2017-03-22 01:40 +0100
    Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen Stanislaw Gruszka <sgruszka@redhat.com> - 2017-03-22 10:10 +0100
      Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen Ankur Arora <ankur.a.arora@oracle.com> - 2017-03-22 19:00 +0100
        Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen Stanislaw Gruszka <sgruszka@redhat.com> - 2017-03-23 14:20 +0100
  Re: [Xen-devel] [PATCH 0/2 v2] xen/acpi: upload PM state from  init-domain to Xen Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-03-23 17:50 +0100
    Re: [Xen-devel] [PATCH 0/2 v2] xen/acpi: upload PM state from  init-domain to Xen Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2017-03-24 15:20 +0100

csiph-web