Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1605775

Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before first use

From Soheil Hassas Yeganeh <soheil@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before first use
Date 2017-03-21 17:30 +0100
Message-ID <tnuPw-5O6-15@gated-at.bofh.it> (permalink)
References <tnuFQ-5IV-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Mar 21, 2017 at 12:14 PM, Alexander Potapenko <glider@google.com> wrote:
> In the case udp_sk(sk)->pending is AF_INET6, udpv6_sendmsg() would
> jump to do_append_data, skipping the initialization of sockc.tsflags.
> Fix the problem by moving sockc.tsflags initialization earlier.
>
> The bug was detected with KMSAN.

Nice catch and thanks for the fix! This is missing a "fixes"
attribution, added below.

> Signed-off-by: Alexander Potapenko <glider@google.com>

Fixes: c14ac9451c34 ("sock: enable timestamping using control messages")
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ipv6: make sure to initialize sockc.tsflags before first use Alexander Potapenko <glider@google.com> - 2017-03-21 17:20 +0100
  Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before first use Soheil Hassas Yeganeh <soheil@google.com> - 2017-03-21 17:30 +0100
  Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before  first use David Miller <davem@davemloft.net> - 2017-03-22 20:50 +0100

csiph-web