Re: [RFC PATCH 3/4] pinctrl: rockchip: split out verification of mux settings

From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 3/4] pinctrl: rockchip: split out verification of mux settings
Date	2017-03-15 17:40 +0100
Message-ID	<tlk7T-1MF-1@gated-at.bofh.it> (permalink)
References	<tkD2V-4vZ-3@gated-at.bofh.it> <tkD2W-4vZ-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Montag, 13. März 2017, 18:38:12 CET schrieb John Keeping:
> We need to avoid calling regmap functions from irq handlers, so the next
> commit is going to move the call to rockchip_set_mux() into an
> irq_bus_sync_unlock handler.  But we can't return an error from there so
> we still need to check the settings from rockchip_irq_set_type() and we
> will use this new rockchip_verify_mux() function from there.
> 
> Signed-off-by: John Keeping <john@metanate.com>

straightforward separation of the verification code
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC PATCH 3/4] pinctrl: rockchip: split out verification of mux settings Heiko Stuebner <heiko@sntech.de> - 2017-03-15 17:40 +0100

csiph-web