Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601194

Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi

Show all headers | View raw

Hi Heiko

On 03/15/2017 05:03 PM, Heiko Stübner wrote:
> Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong:
>> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver,
>> add the description for this clock.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>> ---
>>
>>   .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt       | 2
>> +- 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt index 188f6f7..7e17a60 100644
>> ---
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt +++
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt @@ -10,7 +10,7 @@ Required properties:
>>   - interrupts: Represent the controller's interrupt to the CPU(s).
>>   - clocks, clock-names: Phandles to the controller's pll reference
>>     clock(ref) and APB clock(pclk). For RK3399, a phy config clock
>> -  (phy_cfg) is additional required. As described in [1].
>> +  (phy_cfg) and a grf clock(grf) are additional required. As described in
>> [1].
> your "grf" clock is optional, as it is not present on all socs (like the
> rk3288) so should probably move to a separate section and not be in the
> required properties
For RK3399, the grf clock is required, according to the advice provided 
by rob[0],
put it into "required properties " is better.
[0] https://patchwork.kernel.org/patch/9220187/
>
> Heiko
>
>
>

-- 
Chris Zhong

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Chris Zhong <zyw@rock-chips.com> - 2017-03-15 09:50 +0100
  [PATCH 2/3] drm/rockchip/dsi: enable the grf clk before writing grf registers Chris Zhong <zyw@rock-chips.com> - 2017-03-15 09:50 +0100
    Re: [PATCH 2/3] drm/rockchip/dsi: enable the grf clk before writing  grf registers Brian Norris <briannorris@chromium.org> - 2017-03-15 18:00 +0100
      Re: [PATCH 2/3] drm/rockchip/dsi: enable the grf clk before writing  grf registers John Keeping <john@metanate.com> - 2017-03-15 18:00 +0100
  [PATCH 3/3] drm/rockchip/dsi: correct the grf_switch_reg name Chris Zhong <zyw@rock-chips.com> - 2017-03-15 09:50 +0100
  Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Heiko Stübner <heiko@sntech.de> - 2017-03-15 10:10 +0100
    Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Chris Zhong <zyw@rock-chips.com> - 2017-03-15 11:00 +0100
      Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Heiko Stübner <heiko@sntech.de> - 2017-03-15 11:20 +0100

csiph-web