Re: [PATCH 05/19] gpio: 104-dio-48e: make use of raw_spinlock variants

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/19] gpio: 104-dio-48e: make use of raw_spinlock variants
Date	2017-03-15 11:00 +0100
Message-ID	<tldSN-5Pm-3@gated-at.bofh.it> (permalink)
References	<tj9gC-7KS-21@gated-at.bofh.it> <tj9JD-8bY-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 9, 2017 at 5:21 PM, Julia Cartwright <julia@ni.com> wrote:

> The 104-dio-48e gpio driver currently implements an irq_chip for
> handling interrupts; due to how irq_chip handling is done, it's
> necessary for the irq_chip methods to be invoked from hardirq context,
> even on a a real-time kernel.  Because the spinlock_t type becomes a
> "sleeping" spinlock w/ RT kernels, it is not suitable to be used with
> irq_chips.
>
> A quick audit of the operations under the lock reveal that they do only
> minimal, bounded work, and are therefore safe to do under a raw spinlock.
>
> Signed-off-by: Julia Cartwright <julia@ni.com>

Patch applied with Williams ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 05/19] gpio: 104-dio-48e: make use of raw_spinlock variants Linus Walleij <linus.walleij@linaro.org> - 2017-03-15 11:00 +0100

csiph-web