Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602982

Re: [PATCH v4 1/2] usbip: Fix-format-overflow

Show all headers | View raw

On Thu, Mar 16, 2017 at 09:04:54AM -0600, Shuah Khan wrote:
> On 02/27/2017 01:31 AM, Jonathan Dieter wrote:
> > The usbip userspace tools call sprintf()/snprintf() and don't check for
> > the return value which can lead the paths to overflow, truncating the
> > final file in the path.
> > 
> > More urgently, GCC 7 now warns that these aren't checked with
> > -Wformat-overflow, and with -Werror enabled in configure.ac, that makes
> > these tools unbuildable.
> > 
> > This patch fixes these problems by replacing sprintf() with snprintf() in
> > one place and adding checks for the return value of snprintf().
> > 
> > Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> > Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
> 
> Greg,
> 
> Please pick this up.
> 
> Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

Thanks, still digging through USB patches...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/2] usbip: Fix-format-overflow Shuah Khan <shuah@kernel.org> - 2017-03-16 16:10 +0100
  Re: [PATCH v4 1/2] usbip: Fix-format-overflow Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-17 02:50 +0100

csiph-web