Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600965

Re: [PATCH 2/4] misc: ds1682: Add OF device ID table

Show all headers | View raw

Hello Arnd,

Thanks a lot for your feedback.

On 03/14/2017 05:46 PM, Arnd Bergmann wrote:
> On Tue, Mar 14, 2017 at 4:16 PM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
> 
>> +static const struct of_device_id ds1682_of_match[] = {
>> +       { .compatible = "dallas,ds1682", },
>> +       {}
>> +};
>> +MODULE_DEVICE_TABLE(of, ds1682_of_match);
>> +
>>  static struct i2c_driver ds1682_driver = {
>>         .driver = {
>>                 .name = "ds1682",
>> +               .of_match_table = of_match_ptr(ds1682_of_match),
>>         },
>>         .probe = ds1682_probe,
>>         .remove = ds1682_remove,
> 
> This will cause a warning if CONFIG_OF is disabled, since ds1682_of_match
> becomes unused in this case. Please remove the of_match_ptr() around
> the reference to ds1682_of_match.
>

Right, I tested it when CONFIG_OF is disabled with gcc (GCC) 6.3.1 20161221
and I didn't see any warning. But you are right and I'll re-spin the series
without using the macro.

>     Arnd
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] misc: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
  [PATCH 1/4] misc: tsl2550: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
    Re: [PATCH 1/4] misc: tsl2550: Add OF device ID table Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:00 +0100
  [PATCH 3/4] eeprom: idt_89hpesx: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
  [PATCH 2/4] misc: ds1682: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
    Re: [PATCH 2/4] misc: ds1682: Add OF device ID table Arnd Bergmann <arnd@arndb.de> - 2017-03-14 21:50 +0100
      Re: [PATCH 2/4] misc: ds1682: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 01:40 +0100
        Re: [PATCH 2/4] misc: ds1682: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 04:30 +0100
  [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-14 16:30 +0100
    Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-15 00:10 +0100
      Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 01:20 +0100
        Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-15 09:00 +0100
          Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 12:10 +0100
            Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-15 12:30 +0100
              Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-15 12:50 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-15 23:50 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 13:30 +0100
            Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-16 14:10 +0100
              Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 14:20 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-16 14:40 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 15:10 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-03-16 16:10 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 16:40 +0100
                Re: [PATCH 4/4] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-20 17:50 +0100

csiph-web