Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598924

Re: [PATCH 00/26] x86: 5-level paging enabling for v4.12

Show all headers | View raw

* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:

> Kirill A. Shutemov (26):
>   x86: basic changes into headers for 5-level paging
>   x86: trivial portion of 5-level paging conversion
>   x86/gup: add 5-level paging support
>   x86/ident_map: add 5-level paging support
>   x86/mm: add support of p4d_t in vmalloc_fault()
>   x86/power: support p4d_t in hibernate code
>   x86/kexec: support p4d_t
>   x86/efi: handle p4d in EFI pagetables
>   x86/mm/pat: handle additional page table
>   x86/kasan: prepare clear_pgds() to switch to
>     <asm-generic/pgtable-nop4d.h>
>   x86/xen: convert __xen_pgd_walk() and xen_cleanmfnmap() to support p4d
>   x86: convert the rest of the code to support p4d_t
>   x86: detect 5-level paging support
>   x86/asm: remove __VIRTUAL_MASK_SHIFT==47 assert
>   x86/mm: define virtual memory map for 5-level paging
>   x86/paravirt: make paravirt code support 5-level paging
>   x86/mm: basic defines/helpers for CONFIG_X86_5LEVEL
>   x86/dump_pagetables: support 5-level paging
>   x86/kasan: extend to support 5-level paging
>   x86/espfix: support 5-level paging
>   x86/mm: add support of additional page table level during early boot
>   x86/mm: add sync_global_pgds() for configuration with 5-level paging
>   x86/mm: make kernel_physical_mapping_init() support 5-level paging
>   x86/mm: add support for 5-level paging for KASLR
>   x86: enable 5-level paging support
>   x86/mm: allow to have userspace mappings above 47-bits

Since we are cleaning up the series anyway, please fix the patch titles as well:

 - Please try to find the proper subsystem marker instead of a generic 'x86: ' 
   prefix. For example:

      x86: basic changes into headers for 5-level paging

   ... can be prefixed with "x86/headers: ..." or "x86/mm: ..."

 - Please always start the titles with verbs, to make it easy to parse 
   shortlogs and git oneliner logs quickly. I.e. instead of:

      x86: basic changes into headers for 5-level paging

   Use something like:

      x86/mm: Apply basic changes into headers for 5-level paging

 - Please capitalize them consistently, i.e. "x86/subsystem: Verb ...", with the 
   verb in upper case.

 - Also, please _read_ the titles and the changelogs, for example "basic changes 
   into headers" is not a valid, easy to parse English sentence...

I.e. applying all these 4 principles to the first line turns it from:

      x86: basic changes into headers for 5-level paging

... into something much more informative and easier to read:

      x86/mm: Extend headers with basic definitions to support 5-level paging

Please do this for all the other patches as well - almost all of them have one 
deficiency or some other, several have multiple such deficiencnies.

Ok?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/26] x86: 5-level paging enabling for v4.12 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-13 07:00 +0100
  [PATCH 12/26] x86: convert the rest of the code to support p4d_t "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-13 07:00 +0100
  [PATCH 16/26] x86/paravirt: make paravirt code support 5-level paging "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-13 07:00 +0100
  Re: [PATCH 00/26] x86: 5-level paging enabling for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-03-13 08:50 +0100

csiph-web