Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver
Date	2017-03-12 19:00 +0100
Message-ID	<tkfWG-4O6-5@gated-at.bofh.it> (permalink)
References	<tj5Zn-5Ce-3@gated-at.bofh.it> <tj5Zo-5Ce-33@gated-at.bofh.it> <tj5Zo-5Ce-31@gated-at.bofh.it> <tkftD-4Di-1@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

On 03/12/2017 08:28 PM, Sergei Shtylyov wrote:

>> +static void pata_bk3710_set_piomode(struct ata_port *ap,
>> +                    struct ata_device *adev)
>> +{
>> +    void __iomem *base = (void __iomem *)ap->ioaddr.bmdma_addr;
>> +    struct ata_device *pair = ata_dev_pair(adev);
>> +    const struct ata_timing *t = ata_timing_find_mode(adev->pio_mode);
>> +    const u16 *id = adev->id;
>> +    unsigned int cycle_time;
>> +    int is_slave = adev->devno;
>> +    const u8 pio = adev->pio_mode - XFER_PIO_0;
>> +
>> +    if (id[ATA_ID_FIELD_VALID] & 2) {
>> +        if (ata_id_has_iordy(id))
>> +            cycle_time = id[ATA_ID_EIDE_PIO_IORDY];
>> +        else
>> +            cycle_time = id[ATA_ID_EIDE_PIO];
>> +
>> +        /* conservative "downgrade" for all pre-ATA2 drives */
>> +        if (pio < 3 && cycle_time < t->cycle)
>> +            cycle_time = 0; /* use standard timing */
>> +    }
>> +
>> +    if (!cycle_time)
>> +        cycle_time = t->cycle;
>
>    This seems like a helper needed by libata in general but OK...

    No, the build bot had already reported the problem with 'cycle_time' here, 
I just forgot about it.

[...]
>
>    Well, no serious issues found, so you can stamp:
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

    Too early, it seems... :-)

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-09 14:10 +0100
  [PATCH 3/3] ARM: davinci_all_defconfig: convert to use libata PATA Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-09 14:10 +0100
  [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-09 14:10 +0100
    Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-09 18:10 +0100
      Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-09 21:50 +0100
    Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver kbuild test robot <lkp@intel.com> - 2017-03-11 06:10 +0100
    Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-12 18:30 +0100
      Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-12 19:00 +0100

csiph-web