Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600422
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data |
| Date | 2017-03-14 14:50 +0100 |
| Message-ID | <tkUZR-Q3-45@gated-at.bofh.it> (permalink) |
| References | <tkDvX-501-13@gated-at.bofh.it> <tkUGv-Hf-47@gated-at.bofh.it> <tkDvY-501-35@gated-at.bofh.it> <tkUGv-Hf-45@gated-at.bofh.it> <tkUGw-Hf-75@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/14/2017 06:20 AM, Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 3:17 PM, Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: >> >> Hi, >> >> On Monday, March 13, 2017 09:07:25 PM Krzysztof Kozlowski wrote: >>> Simplify the flow in helper function for getting the driver data by >>> using of_device_get_match_data() and only one if() branch. >>> >>> The code should be equivalent. >> >> While you are at it could you remove s3c2410_get_wdt_drv_data() >> helper? It is used only once during probe and is marked inline >> anyway.. > > Thanks for feedback! > The existence of this helper is purely from code readability (thus > inline does not matter). The probe is big so splitting some small > self-contained part helps. Not much but a little... > Agreed. I don't see value in removing this helper. Guenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/3] watchdog: s3c2410: Minor cleanups Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-13 20:10 +0100
[PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-13 20:10 +0100
Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 14:30 +0100
Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 14:30 +0100
Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data Guenter Roeck <linux@roeck-us.net> - 2017-03-14 14:50 +0100
Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data Guenter Roeck <linux@roeck-us.net> - 2017-03-14 14:50 +0100
csiph-web