Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards
Date	2017-03-14 14:40 +0100
Message-ID	<tkUQ9-Mo-19@gated-at.bofh.it> (permalink)
References	<tjT05-5YC-3@gated-at.bofh.it> <tkUdt-cW-41@gated-at.bofh.it> <tkUQ9-Mo-21@gated-at.bofh.it> <tkUn7-x2-17@gated-at.bofh.it> <tkUQa-Mo-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 14, 2017 at 3:30 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> On Tuesday, March 14, 2017 03:04:28 PM Krzysztof Kozlowski wrote:
>> On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz
>> <b.zolnierkie@samsung.com> wrote:
>> >
>> > Hi,
>> >
>> > On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote:
>> >> Watchdog module does not have external dependencies so it can be safely
>> >> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based
>> >> boards.
>> >>
>> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> >
>> > Please first fix the driver w.r.t. infinite interrupt in soft mode
>> > issue and only then enable it on more hardware.  IOW this patch
>> > should be placed after patch #7 in the series.
>>
>> The soft-interrupt mode is not the default one so this should not
>> cause any issues by default but I got your point. Makes sense. The
>> pity is the timing. There wasn't much interest in the patchset (no
>> comments since 24 of Feb) so I merged it yesterday evening. Does it
>> brake any platform/board?
>
> OK, let it be as it as it doesn't break the default setup.
>
> However please consider the fact that posting revised patches
> (v2 was posted *yesterday*) for a review and then merging them
> the same day is not a good practice..

v2 was posted on March 11, not yesterday but I got the point that the
rest of world is working from Monday not Sunday. :) And v1 was on 24
of Feb. Usually I try to give them more time but recently there is so
less interest in this that I gave up waiting. I will give them more
time in the future.

Thanks for review!

Krzysztof

Thread

[PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 18:30 +0100
  Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx  boards Guenter Roeck <linux@roeck-us.net> - 2017-03-12 21:50 +0100
  Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx  boards Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 14:00 +0100
    Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 14:10 +0100
      Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 14:40 +0100
      Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx  boards Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 14:40 +0100

csiph-web