Re: [PATCH] clocksource: add missing line break to error messages

From	Ben Dooks <ben.dooks@codethink.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clocksource: add missing line break to error messages
Date	2017-03-14 10:50 +0100
Message-ID	<tkRfB-6BP-41@gated-at.bofh.it> (permalink)
References	<tj2RP-3lW-17@gated-at.bofh.it>
Organization	Codethink Limited.

Show all headers | View raw

On 09/03/17 09:47, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Printing with pr_* functions requires adding line break manually.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

I've had a quick look over and there are no obvious errors.

I wonder if the of_iomap() and related calls should print an
error if they fail as all the examples here are of the form
of:

	ptr = of_iomap(reource)
	if (!ptr) {
		pr_err("cannot remap resource\n");
		...
		return ERR;
	}

Maybe we should look into this post this patch series.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: add missing line break to error messages Rafał Miłecki <zajec5@gmail.com> - 2017-03-09 10:50 +0100
  Re: [PATCH] clocksource: add missing line break to error messages Thierry Reding <thierry.reding@gmail.com> - 2017-03-13 19:00 +0100
  Re: [PATCH] clocksource: add missing line break to error messages Ben Dooks <ben.dooks@codethink.co.uk> - 2017-03-14 10:50 +0100

csiph-web