Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1600009

Re: [PATCH v2] mm: fix condition for throttle_direct_reclaim

From "Hillf Danton" <hillf.zj@alibaba-inc.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] mm: fix condition for throttle_direct_reclaim
Date 2017-03-14 04:10 +0100
Message-ID <tkL0t-2gr-1@gated-at.bofh.it> (permalink)
References <tkGDw-7lk-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On March 14, 2017 6:19 AM Shakeel Butt wrote: 
> 
> Recently kswapd has been modified to give up after MAX_RECLAIM_RETRIES
> number of unsucessful iterations. Before going to sleep, kswapd thread
> will unconditionally wakeup all threads sleeping on pfmemalloc_wait.
> However the awoken threads will recheck the watermarks and wake the
> kswapd thread and sleep again on pfmemalloc_wait. There is a chance
> of continuous back and forth between kswapd and direct reclaiming
> threads if the kswapd keep failing and thus defeat the purpose of
> adding backoff mechanism to kswapd. So, add kswapd_failures check
> on the throttle_direct_reclaim condition.
> 
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Suggested-by: Michal Hocko <mhocko@suse.com>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> ---

Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] mm: fix condition for throttle_direct_reclaim Shakeel Butt <shakeelb@google.com> - 2017-03-13 23:30 +0100
  Re: [PATCH v2] mm: fix condition for throttle_direct_reclaim "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-14 04:10 +0100
  Re: [PATCH v2] mm: fix condition for throttle_direct_reclaim Michal Hocko <mhocko@kernel.org> - 2017-03-14 09:20 +0100

csiph-web