Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599908

Re: [PATCH net-next] net: dsa: mv88e6xxx: set out of range ageing time

Show all headers | View raw

On Mon, Mar 13, 2017 at 03:19:32PM -0400, Vivien Didelot wrote:
> The minimum and maximum value of the ATU Age Time varies depending on
> the switch model. The current code returns -ERANGE for out-of-range
> values, and makes switchdev commit phase fail with this stacktrace:

Hi Vivien

I took a look at other switch drivers. mlxsw return ERANGE in the
prepare phase. rocker is not limited, since it is using software
timers.

It seems like the correct way to do this is via a prepare call, or add
min/max fields to struct dsa_switch and let slave.c perform the check.

       Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: dsa: mv88e6xxx: set out of range ageing time Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-13 20:30 +0100
  Re: [PATCH net-next] net: dsa: mv88e6xxx: set out of range ageing  time Andrew Lunn <andrew@lunn.ch> - 2017-03-14 00:00 +0100

csiph-web