Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1598217

[PATCH] ambassador: use setup_timer

From Geliang Tang <geliangtang@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] ambassador: use setup_timer
Date 2017-03-11 01:50 +0100
Message-ID <tjDom-3gr-23@gated-at.bofh.it> (permalink)
References <tjDol-3gr-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/atm/ambassador.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 4a61079..906705e 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -2267,9 +2267,8 @@ static int amb_probe(struct pci_dev *pci_dev,
 	dev->atm_dev->ci_range.vpi_bits = NUM_VPI_BITS;
 	dev->atm_dev->ci_range.vci_bits = NUM_VCI_BITS;
 
-	init_timer(&dev->housekeeping);
-	dev->housekeeping.function = do_housekeeping;
-	dev->housekeeping.data = (unsigned long) dev;
+	setup_timer(&dev->housekeeping, do_housekeeping,
+		    (unsigned long)dev);
 	mod_timer(&dev->housekeeping, jiffies);
 
 	// enable host interrupts
-- 
2.9.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ACPI / APEI: use setup_deferrable_timer Geliang Tang <geliangtang@gmail.com> - 2017-03-11 01:50 +0100
  [PATCH] Bluetooth: bluecard: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-03-11 01:50 +0100
  [PATCH] libata: use setup_deferrable_timer Geliang Tang <geliangtang@gmail.com> - 2017-03-11 01:50 +0100
    Re: [PATCH] libata: use setup_deferrable_timer Tejun Heo <tj@kernel.org> - 2017-03-13 18:10 +0100
  [PATCH] fs/ocfs2/cluster: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-03-11 01:50 +0100
  [PATCH] ambassador: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-03-11 01:50 +0100
    Re: [PATCH] ambassador: use setup_timer David Miller <davem@davemloft.net> - 2017-03-13 07:50 +0100

csiph-web