Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595540

Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node page

Show all headers | View raw

On 03/08, Chao Yu wrote:
> On 2017/3/7 5:51, Jaegeuk Kim wrote:
> > If f2fs_new_inode() is failed, the bad inode will invalidate 0'th node page
> > during f2fs_evict_inode(), which doesn't need to do.
> 
> Hmm...should not allow other using of inode->i_ino in following codes of
> f2fs_evict_inode, right?

Right.

> 
> Thanks,
> 
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  fs/f2fs/inode.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > index 24bb8213d974..ef8610bf950f 100644
> > --- a/fs/f2fs/inode.c
> > +++ b/fs/f2fs/inode.c
> > @@ -411,7 +411,10 @@ void f2fs_evict_inode(struct inode *inode)
> >  	stat_dec_inline_dir(inode);
> >  	stat_dec_inline_inode(inode);
> >  
> > -	invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, inode->i_ino);
> > +	/* ino == 0, if f2fs_new_inode() was failed t*/
> > +	if (inode->i_ino)
> > +		invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino,
> > +							inode->i_ino);
> >  	if (xnid)
> >  		invalidate_mapping_pages(NODE_MAPPING(sbi), xnid, xnid);
> >  	if (inode->i_nlink) {
> > 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: don't need to invalidate wrong node page Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-06 23:00 +0100
  Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node  page Chao Yu <yuchao0@huawei.com> - 2017-03-08 13:20 +0100
    Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node  page Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-08 22:40 +0100
      Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node  page Chao Yu <yuchao0@huawei.com> - 2017-03-09 12:50 +0100

csiph-web