Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595434

[PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

Show all headers | View raw

handle_ept_violation is checking for "guest-linear-address invalid" +
"paging-structure walk", which is a sign of a bug in KVM.  However,
_all_ EPT violations without a valid guest linear address are paging
structure walks, because those EPT violations happen when loading the
guest PDPTEs.  So simplify the check to only look at bit 7 of the
exit qualification.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 arch/x86/kvm/vmx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 89b74d9bc357..cb9034601c7b 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -6232,12 +6232,10 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu)
 	unsigned long exit_qualification;
 	gpa_t gpa;
 	u32 error_code;
-	int gla_validity;
 
 	exit_qualification = vmcs_readl(EXIT_QUALIFICATION);
 
-	gla_validity = (exit_qualification >> 7) & 0x3;
-	if (gla_validity == 0x2) {
+	if ((exit_qualification & 0x80) == 0) {
 		printk(KERN_ERR "EPT: Handling EPT violation failed!\n");
 		printk(KERN_ERR "EPT: GPA: 0x%lx, GVA: 0x%lx\n",
 			(long unsigned int)vmcs_read64(GUEST_PHYSICAL_ADDRESS),
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] KVM: nVMX: nested EPT improvements and A/D bits, RDRAND and RDSEED exits Paolo Bonzini <pbonzini@redhat.com> - 2017-03-08 19:20 +0100
  [PATCH 6/6] KVM: nVMX: support RDRAND and RDSEED exiting Paolo Bonzini <pbonzini@redhat.com> - 2017-03-08 19:20 +0100
    Re: [PATCH 6/6] KVM: nVMX: support RDRAND and RDSEED exiting Jim Mattson <jmattson@google.com> - 2017-03-13 19:30 +0100
  [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation Paolo Bonzini <pbonzini@redhat.com> - 2017-03-08 19:40 +0100
    Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation David Hildenbrand <david@redhat.com> - 2017-03-09 12:00 +0100
      Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation David Hildenbrand <david@redhat.com> - 2017-03-09 12:00 +0100
  [PATCH 1/6] KVM: nVMX: we support 1GB EPT pages Paolo Bonzini <pbonzini@redhat.com> - 2017-03-08 19:40 +0100
    Re: [PATCH 1/6] KVM: nVMX: we support 1GB EPT pages David Hildenbrand <david@redhat.com> - 2017-03-09 11:40 +0100
  [PATCH 4/6] kvm: nVMX: support EPT accessed/dirty bits Paolo Bonzini <pbonzini@redhat.com> - 2017-03-08 19:40 +0100
  [PATCH 3/6] kvm: x86: MMU support for EPT accessed/dirty bits Paolo Bonzini <pbonzini@redhat.com> - 2017-03-08 20:10 +0100

csiph-web