Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595433

Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

Show all headers | View raw

On 03/08/2017 11:25 AM, Rich Felker wrote:
> On Wed, Mar 08, 2017 at 10:53:00AM -0500, Carlos O'Donell wrote:
>> On 11/11/2016 07:08 AM, Felix Janda wrote:
>>> Currently, libc-compat.h detects inclusion of specific glibc headers,
>>> and defines corresponding _UAPI_DEF_* macros, which in turn are used in
>>> uapi headers to prevent definition of conflicting structures/constants.
>>> There is no such detection for other c libraries, for them the
>>> _UAPI_DEF_* macros are always defined as 1, and so none of the possibly
>>> conflicting definitions are suppressed.
>>>
>>> This patch enables non-glibc c libraries to request the suppression of
>>> any specific interface by defining the corresponding _UAPI_DEF_* macro
>>> as 0.
>>>
>>> This patch together with the recent musl libc commit
>>>
>>> http://git.musl-libc.org/cgit/musl/commit/?id=04983f2272382af92eb8f8838964ff944fbb8258
>>
>> Would it be possible to amend the musl patch to define the macros to 1.
> 
> I don't follow. They're defined to 0 explicitly to tell the kernel
> headers not to define their own versions of these structs, etc. since
> they would clash. Defining to 1 would have the opposite meaning.

My apologies, I must have misread the original musl patch.

Defining them to a known value is exactly what I was looking for.

The other outstanding questions remain.

-- 
Cheers,
Carlos.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of  uapi definitions Carlos O'Donell <carlos@redhat.com> - 2017-03-08 17:10 +0100
  Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to  opt out of uapi definitions Rich Felker <dalias@aerifal.cx> - 2017-03-08 17:50 +0100
    Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to  opt out of uapi definitions Carlos O'Donell <carlos@redhat.com> - 2017-03-08 19:40 +0100
  Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of  uapi definitions Szabolcs Nagy <nsz@port70.net> - 2017-03-09 01:50 +0100
    Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of  uapi definitions Carlos O'Donell <carlos@redhat.com> - 2017-03-09 02:10 +0100
      Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to  opt out of uapi definitions Rich Felker <dalias@aerifal.cx> - 2017-03-09 04:10 +0100

csiph-web