[PATCH 16/26] IB/ocrdma: Adjust a null pointer check in ocrdma_alloc_resources()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 16/26] IB/ocrdma: Adjust a null pointer check in ocrdma_alloc_resources()
Date	2017-03-08 16:40 +0100
Message-ID	<tiLxF-8ng-35@gated-at.bofh.it> (permalink)
References	<tiJct-6C3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 7 Mar 2017 22:34:33 +0100

The script "checkpatch.pl" pointed information out like the following.

Comparison to NULL could be written "!dev->stag_arr".

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
index 93113feeb2d5..fbf672c79d5f 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
@@ -238,7 +238,7 @@ static int ocrdma_alloc_resources(struct ocrdma_dev *dev)
 
 	dev->stag_arr = kcalloc(OCRDMA_MAX_STAG, sizeof(*dev->stag_arr),
 				GFP_KERNEL);
-	if (dev->stag_arr == NULL)
+	if (!dev->stag_arr)
 		goto alloc_err;
 
 	ocrdma_alloc_pd_pool(dev);
-- 
2.12.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 16/26] IB/ocrdma: Adjust a null pointer check in  ocrdma_alloc_resources() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 16:40 +0100
  Re: [PATCH 16/26] IB/ocrdma: Adjust a null pointer check in  ocrdma_alloc_resources() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-09 12:50 +0100

csiph-web