Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591035

Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap

Show all headers | View raw

Hi Marc,

On 02/03/2017 11:16, Marc Zyngier wrote:
> On 02/03/17 10:01, Mian Yousaf Kaukab wrote:
>> Fix following build error for s390:
>> drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_attach_group':
>> drivers/vfio/vfio_iommu_type1.c:1290:25: error: implicit declaration of function 'irq_domain_check_msi_remap'
>>
>> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
>> ---
>>  include/linux/irqdomain.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
>> index 188eced6813e..137817b08cdc 100644
>> --- a/include/linux/irqdomain.h
>> +++ b/include/linux/irqdomain.h
>> @@ -524,6 +524,10 @@ static inline struct irq_domain *irq_find_matching_fwnode(
>>  {
>>  	return NULL;
>>  }
>> +static inline bool irq_domain_check_msi_remap(void)
>> +{
>> +	return true;
> 
> I'm not sure about that one. If we don't support reserved regions for
> MSI, why should we return "true" here? My gut feeling is that it should
> be false (because we lack the infrastructure to deal with it).
> 
> It is a bit of a moot point since the only calling site will *not* call
> this in that case, but I believe that we should be consistent.
> 
> Eric, what do you think?

I agree with you. I Would return false here as just commented and I
don't think subsequent patch is needed.

Thanks

Eric
> 
> Thanks,
> 
> 	M.
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap Marc Zyngier <marc.zyngier@arm.com> - 2017-03-02 11:20 +0100
  Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap Auger Eric <eric.auger@redhat.com> - 2017-03-02 13:30 +0100

csiph-web