Re: [PATCH] tpm: select CONFIG_CRYPTO

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: select CONFIG_CRYPTO
Date	2017-03-02 10:20 +0100
Message-ID	<tgv3X-9a-3@gated-at.bofh.it> (permalink)
References	<tfXlF-1rB-43@gated-at.bofh.it> <tfXvk-1v9-37@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote:
> 
> 
> Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd@arndb.de>:
> >We get a newly introduced harmless warning when CONFIG_CRYPTO is
> >disabled:
> >
> >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
> >which has unmet direct dependencies (CRYPTO)
> >
> >This adds another select to avoid the warning, consistent with other
> >users
> >of the crypto code.
> >
> >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
> >multiple banks")
> >Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Lgtm
> 
> Reviewed-by: Peter Huewe <peterhuewe@gmx.de>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> >---
> > drivers/char/tpm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> >index af985cca413c..d520ac51c11c 100644
> >--- a/drivers/char/tpm/Kconfig
> >+++ b/drivers/char/tpm/Kconfig
> >@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> > 	tristate "TPM Hardware Support"
> > 	depends on HAS_IOMEM
> > 	select SECURITYFS
> >+	select CRYPTO
> > 	select CRYPTO_HASH_INFO
> > 	---help---
> > 	  If you have a TPM security chip in your system, which
> 
> -- 
> Sent from my mobile

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] tpm: select CONFIG_CRYPTO Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-02 10:20 +0100

csiph-web