Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590876

Re: [PATCH] zram: reduce load operation in page_same_filled

Show all headers | View raw

Hi Sangwoo,

On Thu, Mar 02, 2017 at 01:15:04PM +0900, Sangwoo wrote:
> In page_same_filled function, all elements in the page is compared
> with next index value. The current comparison routine compares
> the (i)th and (i+1)th values of the page.
> In this case, two load operaions occur for each comparison.
> But if we store first value of the page stores at 'val' variable
> and using it to compare with others, the load opearation is reduced.
> It reduce load operation per page by up to 64times.
> 
> Signed-off-by: Sangwoo <sangwoo2.park@lge.com>

The rule is that you should use your full name Sangwoo Park for SOB. :)
Anyway, Good spot!

FYI,
Ccing Andrew because he merges zram patches to mmotm tree.

Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] zram: reduce load operation in page_same_filled Sangwoo <sangwoo2.park@lge.com> - 2017-03-02 05:20 +0100
  Re: [PATCH] zram: reduce load operation in page_same_filled Minchan Kim <minchan@kernel.org> - 2017-03-02 08:10 +0100
    Re: [PATCH] zram: reduce load operation in page_same_filled Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-02 08:40 +0100

csiph-web