Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590452
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim |
| Date | 2017-03-01 17:00 +0100 |
| Message-ID | <tgePy-5b2-59@gated-at.bofh.it> (permalink) |
| References | <tfZQt-2Vc-9@gated-at.bofh.it> <tg7l0-8hz-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue 28-02-17 16:40:04, Johannes Weiner wrote:
> 246e87a93934 ("memcg: fix get_scan_count() for small targets") sought
> to avoid high reclaim priorities for memcg by forcing it to scan a
> minimum amount of pages when lru_pages >> priority yielded nothing.
> This was done at a time when reclaim decisions like dirty throttling
> were tied to the priority level.
>
> Nowadays, the only meaningful thing still tied to priority dropping
> below DEF_PRIORITY - 2 is gating whether laptop_mode=1 is generally
> allowed to write. But that is from an era where direct reclaim was
> still allowed to call ->writepage, and kswapd nowadays avoids writes
> until it's scanned every clean page in the system. Potential changes
> to how quick sc->may_writepage could trigger are of little concern.
>
> Remove the force_scan stuff, as well as the ugly multi-pass target
> calculation that it necessitated.
I _really_ like this, I hated the multi-pass part. One thig that I am
worried about and changelog doesn't mention it is what we are going to
do about small (<16MB) memcgs. On one hand they were already ignored in
the global reclaim so this is nothing really new but maybe we want to
preserve the behavior for the memcg reclaim at least which would reduce
side effect of this patch which is a great cleanup otherwise. Or at
least be explicit about this in the changelog.
Btw. why cannot we simply force scan at least SWAP_CLUSTER_MAX
unconditionally?
> + /*
> + * If the cgroup's already been deleted, make sure to
> + * scrape out the remaining cache.
Also make sure that small memcgs will not get
unnoticed during the memcg reclaim
> + */
> + if (!scan && !mem_cgroup_online(memcg))
if (!scan && (!mem_cgroup_online(memcg) || !global_reclaim(sc)))
> + scan = min(size, SWAP_CLUSTER_MAX);
>
--
Michal Hocko
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/9] mm: kswapd spinning on unreclaimable nodes - fixes and cleanups Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 01:00 +0100
[PATCH 4/9] mm: remove unnecessary reclaimability check from NUMA balancing target Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 01:10 +0100
Re: [PATCH 4/9] mm: remove unnecessary reclaimability check from NUMA balancing target Michal Hocko <mhocko@kernel.org> - 2017-03-01 20:30 +0100
Re: [PATCH 4/9] mm: remove unnecessary reclaimability check from NUMA balancing target "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-02 04:40 +0100
[PATCH 8/9] Revert "mm, vmscan: account for skipped pages as a partial scan" Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 01:10 +0100
Re: [PATCH 8/9] Revert "mm, vmscan: account for skipped pages as a partial scan" Michal Hocko <mhocko@kernel.org> - 2017-03-01 17:00 +0100
[PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 09:00 +0100
Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating Mel Gorman <mgorman@suse.de> - 2017-03-01 16:20 +0100
Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating Michal Hocko <mhocko@kernel.org> - 2017-03-01 16:50 +0100
Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-02 04:30 +0100
[PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 09:00 +0100
Re: [PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim Michal Hocko <mhocko@kernel.org> - 2017-03-01 17:00 +0100
Re: [PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 19:30 +0100
Re: [PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim Michal Hocko <mhocko@kernel.org> - 2017-03-01 20:20 +0100
Re: [PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-02 04:40 +0100
[PATCH 2/9] mm: fix check for reclaimable pages in PF_MEMALLOC reclaim throttling Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 09:00 +0100
Re: [PATCH 2/9] mm: fix check for reclaimable pages in PF_MEMALLOC reclaim throttling Michal Hocko <mhocko@kernel.org> - 2017-03-01 16:10 +0100
Re: [PATCH 2/9] mm: fix check for reclaimable pages in PF_MEMALLOC reclaim throttling "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-02 04:30 +0100
[PATCH 7/9] mm: delete NR_PAGES_SCANNED and pgdat_reclaimable() Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 09:00 +0100
Re: [PATCH 7/9] mm: delete NR_PAGES_SCANNED and pgdat_reclaimable() Michal Hocko <mhocko@kernel.org> - 2017-03-01 16:50 +0100
[PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 09:00 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-02 04:30 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Shakeel Butt <shakeelb@google.com> - 2017-03-03 02:40 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Minchan Kim <minchan@kernel.org> - 2017-03-03 02:50 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Michal Hocko <mhocko@kernel.org> - 2017-03-03 09:10 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Minchan Kim <minchan@kernel.org> - 2017-03-06 02:40 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Johannes Weiner <hannes@cmpxchg.org> - 2017-03-06 17:40 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-07 02:10 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Minchan Kim <minchan@kernel.org> - 2017-03-07 08:50 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Michal Hocko <mhocko@kernel.org> - 2017-03-07 11:30 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Johannes Weiner <hannes@cmpxchg.org> - 2017-03-07 20:00 +0100
Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes Mel Gorman <mgorman@suse.de> - 2017-03-09 15:40 +0100
[PATCH 9/9] mm: remove unnecessary back-off function when retrying page reclaim Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 15:00 +0100
Re: [PATCH 9/9] mm: remove unnecessary back-off function when retrying page reclaim Michal Hocko <mhocko@kernel.org> - 2017-03-01 16:50 +0100
[PATCH 5/9] mm: don't avoid high-priority reclaim on unreclaimable nodes Johannes Weiner <hannes@cmpxchg.org> - 2017-03-01 15:00 +0100
Re: [PATCH 5/9] mm: don't avoid high-priority reclaim on unreclaimable nodes Michal Hocko <mhocko@kernel.org> - 2017-03-01 17:00 +0100
csiph-web