Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592021

[for-next][PATCH 3/7] module: set __jump_table alignment to 8

Show all headers | View raw

From: David Daney <david.daney@cavium.com>

For powerpc the __jump_table section in modules is not aligned, this
causes a WARN_ON() splat when loading a module containing a __jump_table.

Strict alignment became necessary with commit 3821fd35b58d
("jump_label: Reduce the size of struct static_key"), currently in
linux-next, which uses the two least significant bits of pointers to
__jump_table elements.

Fix by forcing __jump_table to 8, which is the same alignment used for
this section in the kernel proper.

Link: http://lkml.kernel.org/r/20170301220453.4756-1-david.daney@cavium.com

Reviewed-by: Jason Baron <jbaron@akamai.com>
Acked-by: Jessica Yu <jeyu@redhat.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
Signed-off-by: David Daney <david.daney@cavium.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 scripts/module-common.lds | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/module-common.lds b/scripts/module-common.lds
index 73a2c7da0e55..53234e85192a 100644
--- a/scripts/module-common.lds
+++ b/scripts/module-common.lds
@@ -19,4 +19,6 @@ SECTIONS {
 
 	. = ALIGN(8);
 	.init_array		0 : { *(SORT(.init_array.*)) *(.init_array) }
+
+	__jump_table		0 : ALIGN(8) { KEEP(*(__jump_table)) }
 }
-- 
2.10.2

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[for-next][PATCH 0/7] tracing: Fixes for 4.11 Steven Rostedt <rostedt@goodmis.org> - 2017-03-03 15:50 +0100
  [for-next][PATCH 5/7] jump_label: Add comment about initialization order for anonymous  unions Steven Rostedt <rostedt@goodmis.org> - 2017-03-03 15:50 +0100
  [for-next][PATCH 2/7] ftrace/graph: Do not modify the EMPTY_HASH for the function_graph  filter Steven Rostedt <rostedt@goodmis.org> - 2017-03-03 15:50 +0100
  [for-next][PATCH 7/7] ftrace/graph: Add ftrace_graph_max_depth kernel parameter Steven Rostedt <rostedt@goodmis.org> - 2017-03-03 15:50 +0100
  [for-next][PATCH 1/7] tracing: Fix code comment for ftrace_ops_get_func() Steven Rostedt <rostedt@goodmis.org> - 2017-03-03 15:50 +0100
  [for-next][PATCH 3/7] module: set __jump_table alignment to 8 Steven Rostedt <rostedt@goodmis.org> - 2017-03-03 15:50 +0100

csiph-web