Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd

From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd
Date	2017-03-01 04:20 +0100
Message-ID	<tg2Y2-5e0-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <tfXbY-1nX-25@gated-at.bofh.it> <tfXF0-1ys-11@gated-at.bofh.it> <tfXYl-1Fm-7@gated-at.bofh.it> <tfYhH-21y-1@gated-at.bofh.it> <tg0Wd-3Nm-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/28/17 15:16, Guenter Roeck wrote:
> On Tue, Feb 28, 2017 at 10:48:27PM +0100, Arnd Bergmann wrote:
>> On Tue, Feb 28, 2017 at 10:44 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Tue, Feb 28, 2017 at 10:36 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>
>>>>>  config WM831X_WATCHDOG
>>>>>       tristate "WM831x watchdog"
>>>>> -     depends on MFD_WM831X || COMPILE_TEST
>>>>> +     depends on MFD_WM831X
>>>>
>>>> I prefer the fix proposed by Randy:
>>>>
>>>> -       depends on MFD_WM831X || COMPILE_TEST
>>>> +       depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST)
>>>>
>>>
>>> Agreed, that's better.
>>
>> Actually I misread. They should be completely equivalent, the part after
>> the || has no effect here.
>>
> Yes, I figured that out later as well.

Agreed.  Arnd's is simpler.  My patch might keep someone else from
making the same mistake.  ;)


-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/8] watchdog: wm831x watchdog really needs mfd Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:10 +0100
  Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:40 +0100
    Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd Arnd Bergmann <arnd@arndb.de> - 2017-02-28 23:00 +0100
      Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd Arnd Bergmann <arnd@arndb.de> - 2017-02-28 23:20 +0100
        Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd Guenter Roeck <linux@roeck-us.net> - 2017-03-01 02:10 +0100
          Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd Randy Dunlap <rdunlap@infradead.org> - 2017-03-01 04:20 +0100

csiph-web