Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1588835

Re: [PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions
Date 2017-02-27 18:40 +0100
Message-ID <tfxrb-n1-3@gated-at.bofh.it> (permalink)
References <tb6SB-8n6-3@gated-at.bofh.it> <tb6SC-8n6-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Feb 15, 2017 at 12:22:13PM +0000, Luis Oliveira wrote:
> - Definitions were added to core library
> - A example was added to designware-core.txt Documentation that shows
>   how the slave can be setup using DTS
> 
> SLAVE related definitions were added to the core of the controller.
> 
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> V5->V6
> - Included an example of use in the device tree binding document
> 
>  .../devicetree/bindings/i2c/i2c-designware.txt     | 16 +++++++++-
>  drivers/i2c/busses/i2c-designware-core.h           | 35 ++++++++++++++++++++--
>  2 files changed, 48 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> index fee26dc3e858..c6f1d9a63d18 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> @@ -20,7 +20,7 @@ Optional properties :
>   - i2c-sda-falling-time-ns : should contain the SDA falling time in nanoseconds.
>     This value which is by default 300ns is used to compute the tHIGH period.
>  
> -Example :
> +Examples :
>  
>  	i2c@f0000 {
>  		#address-cells = <1>;
> @@ -43,3 +43,17 @@ Example :
>  		i2c-sda-falling-time-ns = <300>;
>  		i2c-scl-falling-time-ns = <300>;
>  	};
> +
> +	i2c@01120000 {

Drop leading 0. With that, for the binding:

Acked-by: Rob Herring <robh@kernel.org>

> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x2000 0x100>;
> +		clock-frequency = <400000>;
> +		clocks = <&i2cclk>;
> +		interrupts = <0>;
> +
> +		eeprom@64 {
> +			compatible = "linux,slave-24c02";
> +			reg = <0x40000064>;
> +		};
> +	};

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-02-15 13:30 +0100
  [PATCH v6 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-02-15 13:30 +0100
  [PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-02-15 13:30 +0100
    Re: [PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions Rob Herring <robh@kernel.org> - 2017-02-27 18:40 +0100
  [PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes. Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-02-15 13:30 +0100
    Re: [PATCH v6 1/6] i2c: designware: Cleaning and comment style  fixes. Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-15 14:20 +0100
      Re: [PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes. Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-02-28 16:20 +0100
  [PATCH v6 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-02-15 13:30 +0100

csiph-web