Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588824

Re: [REGRESSION] pinctrl, of, unable to find hogs

Show all headers | View raw

On Mon, Feb 27, 2017 at 05:27:47PM +0100, Gary Bisson wrote:
> Mika, Tony, All,
> 
> On Mon, Feb 27, 2017 at 07:53:53AM -0800, Tony Lindgren wrote:
> > * Mika Penttilä <mika.penttila@nextfour.com> [170226 21:46]:
> > > 
> > > With current linus git (pre 4.11), unable to find the pinctrl hogs :
> > > 
> > > 
> > >  imx6q-pinctrl 20e0000.iomuxc: unable to find group for node hoggrp
> > > 
> > > 
> > > Device is i.MX6 based.
> > 
> > Sorry to hear about that, maybe imx_pinctrl_probe_dt() should be
> > called before devm_pinctrl_register_and_init()?
> > 
> > Things got moved around a bit with e566fc11ea76 ("pinctrl: imx: use
> > generic pinctrl helpers for managing groups") it seems. But maybe that
> > was done because we did not have commit 950b0d91dc10 ("pinctrl: core:
> > Fix regression caused by delayed work for hogs") when the imx_pinctrl
> > changes got merged.
> 
> Indeed the i.MX changes were made before your the rework.

s/the/hog/

> The reason imx_pinctrl_probe_dt got moved around is because
> devm_pinctrl_register is the one that initializes the radix trees that
> are needed when probing the dt.
> 
> > Gary, are you able to reproduce this? Seems it should happen with
> > any imx with hogs configured in the dts.
> 
> Yes I can reproduce the issue.
> 
> Not sure how to fix it though since we can't move the dt probing before
> radix tree init.
> 
> Regards,
> Gary

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [REGRESSION] pinctrl, of, unable to find hogs Gary Bisson <gary.bisson@boundarydevices.com> - 2017-02-27 17:40 +0100
  Re: [REGRESSION] pinctrl, of, unable to find hogs Gary Bisson <gary.bisson@boundarydevices.com> - 2017-02-27 18:20 +0100
    Re: [REGRESSION] pinctrl, of, unable to find hogs Tony Lindgren <tony@atomide.com> - 2017-02-27 19:40 +0100
      Re: [REGRESSION] pinctrl, of, unable to find hogs Gary Bisson <gary.bisson@boundarydevices.com> - 2017-02-27 23:30 +0100
        Re: [REGRESSION] pinctrl, of, unable to find hogs Tony Lindgren <tony@atomide.com> - 2017-02-28 00:50 +0100
          Re: [REGRESSION] pinctrl, of, unable to find hogs Gary Bisson <gary.bisson@boundarydevices.com> - 2017-02-28 10:40 +0100
            Re: [REGRESSION] pinctrl, of, unable to find hogs Tony Lindgren <tony@atomide.com> - 2017-02-28 18:30 +0100
      Re: [REGRESSION] pinctrl, of, unable to find hogs Tony Lindgren <tony@atomide.com> - 2017-02-27 23:40 +0100

csiph-web