Re: [PATCH 3/7] net: stmmac: Check for DMA mapping errors

From	Mikko Perttunen <cyndis@kapsi.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] net: stmmac: Check for DMA mapping errors
Date	2017-02-27 11:40 +0100
Message-ID	<tfqSJ-4fZ-1@gated-at.bofh.it> (permalink)
References	<te5nj-4nQ-5@gated-at.bofh.it> <te5nj-4nQ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 23.02.2017 19:24, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> When DMA mapping an SKB fragment, the mapping must be checked for
> errors, otherwise the DMA debug code will complain upon unmap.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 6b7a5ce19589..d7387919bdb6 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2072,6 +2072,8 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)
>  		des = skb_frag_dma_map(priv->device, frag, 0,
>  				       skb_frag_size(frag),
>  				       DMA_TO_DEVICE);
> +		if (dma_mapping_error(priv->device, des))
> +			goto dma_map_err;

If this map fails, we should also unmap the previously mapped fragments 
and the separate mapping made using dma_map_single.

>
>  		stmmac_tso_allocator(priv, des, skb_frag_size(frag),
>  				     (i == nfrags - 1));
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/7] net: stmmac: Check for DMA mapping errors Thierry Reding <thierry.reding@gmail.com> - 2017-02-23 18:30 +0100
  Re: [PATCH 3/7] net: stmmac: Check for DMA mapping errors Mikko Perttunen <cyndis@kapsi.fi> - 2017-02-27 11:40 +0100

csiph-web