Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588371

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

Show all headers | View raw

On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote:

> This was reported by checkpatch.pl
>
> Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Actually, the outreachy tutorial says not to send patches to mailing
lists, only to people (except in the case of IIO, where the maintainers
asked for patches to be sent to mailing lists as well).  The
get_maintainer command to use is shown here:

https://kernelnewbies.org/FirstKernelPatch#submit_a_patch

> ---
>  drivers/staging/bcm2835-audio/bcm2835-pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> index 9e79236..328bee4a 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> @@ -91,7 +91,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream)
>  		frames_to_bytes(alsa_stream->substream->runtime, alsa_stream->substream->runtime->status->hw_ptr),
>  		new_period);
>  	if (alsa_stream->buffer_size) {
> -		alsa_stream->pos += consumed &~(1 << 30);
> +		alsa_stream->pos += consumed & ~(1 << 30);
>  		alsa_stream->pos %= alsa_stream->buffer_size;
>  	}
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488131271-2908-1-git-send-email-narcisaanamaria12%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: bcm2835-audio: Fixed spacing around '&' Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com> - 2017-02-26 19:00 +0100
  Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing  around '&' Julia Lawall <julia.lawall@lip6.fr> - 2017-02-26 19:30 +0100
    Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed  spacing around '&' Joe Perches <joe@perches.com> - 2017-02-26 19:40 +0100
      Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed  spacing around '&' Joe Perches <joe@perches.com> - 2017-02-26 20:40 +0100
        Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing  around '&' Julia Lawall <julia.lawall@lip6.fr> - 2017-02-26 21:50 +0100
          Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed  spacing around '&' Joe Perches <joe@perches.com> - 2017-02-26 23:00 +0100
            Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing  around '&' Scott Branden <scott.branden@broadcom.com> - 2017-02-27 01:10 +0100
              Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing  around '&' Julia Lawall <julia.lawall@lip6.fr> - 2017-02-27 07:50 +0100
                Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing  around '&' Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-27 15:50 +0100
                Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing  around '&' Scott Branden <scott.branden@broadcom.com> - 2017-02-27 21:50 +0100
                Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed  spacing around '&' Michael Zoran <mzoran@crowfest.net> - 2017-02-27 23:10 +0100
      Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing  around '&' Julia Lawall <julia.lawall@lip6.fr> - 2017-02-27 01:50 +0100

csiph-web