Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589754

Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked()

Show all headers | View raw

On 28 February 2017 at 19:35, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Feb 28, 2017 at 10:01:10AM +0100, Daniel Vetter wrote:
>
>> > +   ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr,
>> > +                   vsg->num_pages, vsg->pages,
>> > +                   (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0);
>
> Umm...  Why not
>         ret = get_user_pages_fast((unsigned long)xfer->mem_addr,
>                         vsg->num_pages,
>                         vsg->direction == DMA_FROM_DEVICE,
>                         vsg->pages);
>
> IOW, do you really need a warranty that ->mmap_sem will be grabbed and
> released?

Daniel will be better placed to answer in this specific case, but more
generally is there any reason why we can't just use
get_user_pages_fast() in all such cases? These patches were simply a
mechanical/cautious replacement for code that is more or less exactly
equivalent but if this would make sense perhaps it'd be worth using
gup_fast() where possible?

-- 
Lorenzo Stoakes
https://ljs.io

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] drm/via: use get_user_pages_unlocked() Lorenzo Stoakes <lstoakes@gmail.com> - 2017-02-27 23:20 +0100
  Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked() Daniel Vetter <daniel@ffwll.ch> - 2017-02-28 10:10 +0100
    Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked() Al Viro <viro@ZenIV.linux.org.uk> - 2017-02-28 20:40 +0100
      Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked() Lorenzo Stoakes <lstoakes@gmail.com> - 2017-02-28 21:40 +0100
        Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked() Daniel Vetter <daniel@ffwll.ch> - 2017-03-01 09:50 +0100

csiph-web