Re: [PATCH] ide: palm_bk3710: add __initdata to palm_bk3710_port_info

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ide: palm_bk3710: add __initdata to palm_bk3710_port_info
Date	2017-02-28 03:10 +0100
Message-ID	<tfFoJ-67K-3@gated-at.bofh.it> (permalink)
References	<sU1FD-2uQ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 30 Dec 2016 14:50:02 +0530

> The object palm_bk3710_port_info of type ide_port_info is never
> referenced anywhere after initialization by palm_bk3710_probe. It is
> also passed as a parameter to ide_host_add which is called from the init
> function but this call doesn't store the object reference anywhere, and
> it only dereferences the values of the fields. Therefore add __initdata
> to its declaration.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied, thanks.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ide: palm_bk3710: add __initdata to  palm_bk3710_port_info David Miller <davem@davemloft.net> - 2017-02-28 03:10 +0100

csiph-web