Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588256

Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for hi3798cv200 SoC and Poplar board

Show all headers | View raw

Am 22.02.2017 um 09:38 schrieb Jiancheng Xue:
> Add bindings for HiSilicon hi3798cv200 SoC and Poplar Board.
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
> ---
>  Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> index f1c1e21..1fd3dd7 100644
> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> @@ -4,6 +4,10 @@ Hi3660 SoC
>  Required root node properties:
>  	- compatible = "hisilicon,hi3660";
>  
> +Hi3798cv200 Poplar Board
> +Required root node properties:
> +	- compatible = "hisilicon,hi3798cv200-poplar", "hisilicon,hi3798cv200";

Please remember to CC previous reviewers.

This still looks wrong: Why is this not "hisilicon,poplar" if you choose
against "tocoding,poplar"? Is there a second Poplar board with a
different SoC? Even then it would be redundant with the second
compatible string.

Regards,
Andreas

> +
>  Hi4511 Board
>  Required root node properties:
>  	- compatible = "hisilicon,hi3620-hi4511";

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] add dts files for hi3798cv200-Poplar board Jiancheng Xue <xuejiancheng@hisilicon.com> - 2017-02-22 10:00 +0100
  [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for hi3798cv200 SoC and Poplar board Jiancheng Xue <xuejiancheng@hisilicon.com> - 2017-02-22 10:00 +0100
    Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Alex Elder <elder@linaro.org> - 2017-02-22 15:40 +0100
    Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Peter Griffin <peter.griffin@linaro.org> - 2017-02-25 11:30 +0100
    Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Andreas Färber <afaerber@suse.de> - 2017-02-26 02:40 +0100
      Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Jiancheng Xue <xuejiancheng@hisilicon.com> - 2017-02-27 02:30 +0100
        Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Alex Elder <elder@linaro.org> - 2017-02-27 04:00 +0100
          Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Andreas Färber <afaerber@suse.de> - 2017-02-27 16:30 +0100
            Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Peter Griffin <peter.griffin@linaro.org> - 2017-02-28 12:50 +0100
    Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for  hi3798cv200 SoC and Poplar board Rob Herring <robh@kernel.org> - 2017-02-27 23:40 +0100
  [PATCH v2 2/2] arm64: dts: hisilicon: add dts files for hi3798cv200-poplar board Jiancheng Xue <xuejiancheng@hisilicon.com> - 2017-02-22 10:00 +0100
    Re: [PATCH v2 2/2] arm64: dts: hisilicon: add dts files for  hi3798cv200-poplar board Peter Griffin <peter.griffin@linaro.org> - 2017-02-25 11:30 +0100
    Re: [PATCH v2 2/2] arm64: dts: hisilicon: add dts files for  hi3798cv200-poplar board Andreas Färber <afaerber@suse.de> - 2017-02-26 03:00 +0100

csiph-web