Re: [PATCH v2] gpio: xgene: mark PM functions as __maybe_unused

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] gpio: xgene: mark PM functions as __maybe_unused
Date	2017-02-23 16:00 +0100
Message-ID	<te329-2EY-1@gated-at.bofh.it> (permalink)
References	<tbSuf-5X8-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 17, 2017 at 4:13 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions:
>
> drivers/gpio/gpio-xgene.c:155:12: warning: 'xgene_gpio_resume' defined but not used [-Wunused-function]
>  static int xgene_gpio_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-xgene.c:142:12: warning: 'xgene_gpio_suspend' defined but not used [-Wunused-function]
>  static int xgene_gpio_suspend(struct device *dev)
>
> The warnings are harmless and can be avoided by simplifying the code and marking
> the functions as __maybe_unused.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: remove #ifdef around set_dr_val as well, to avoid build regression

Patch applied for fixes.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpio: xgene: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-02-17 16:20 +0100
  Re: [PATCH v2] gpio: xgene: mark PM functions as __maybe_unused Linus Walleij <linus.walleij@linaro.org> - 2017-02-23 16:00 +0100

csiph-web