Re: [PATCH] kernfs: fix locking around kernfs_ops->release() callback

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kernfs: fix locking around kernfs_ops->release() callback
Date	2017-02-21 22:00 +0100
Message-ID	<tdpHs-7P4-21@gated-at.bofh.it> (permalink)
References	<t9MCB-5gO-11@gated-at.bofh.it> <t9MCB-5gO-13@gated-at.bofh.it> <t9MCB-5gO-15@gated-at.bofh.it> <t9MCB-5gO-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 12, 2017 at 05:33:02AM +0900, Tejun Heo wrote:
> The release callback may be called from two places - file release
> operation and kernfs open file draining.  kernfs_open_file->mutex is
> used to synchronize the two callsites.  This unfortunately leads to
> possible circular locking because of->mutex is used to protect the
> usual kernfs operations which may use locking constructs which are
> held while removing and thus draining kernfs files.
> 
> @of->mutex is for synchronizing concurrent kernfs access operations
> and all we need here is synchronization between the releaes and drain
> paths.  As the drain path has to grab kernfs_open_file_mutex anyway,
> let's use the mutex to synchronize the release operation instead.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Tony Lindgren <tony@atomide.com>
> Fixes: 0e67db2f9fe9 ("kernfs: add kernfs_ops->open/release() callbacks")

Applied to cgroup/for-4.11.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] kernfs: fix locking around kernfs_ops->release() callback Tejun Heo <tj@kernel.org> - 2017-02-21 22:00 +0100

csiph-web