Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586051
| From | "Tobin C. Harding" <me@tobin.cc> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ALSA: emu10k1: Remove cast from memory allocation |
| Date | 2017-02-22 11:40 +0100 |
| Message-ID | <tdCv0-eA-5@gated-at.bofh.it> (permalink) |
| References | <tdyUp-5Yo-7@gated-at.bofh.it> <tdzdL-6lr-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Feb 22, 2017 at 07:59:57AM +0100, Takashi Iwai wrote: > On Wed, 22 Feb 2017 07:47:16 +0100, > Tobin C. Harding wrote: > > > > Coccinelle emits multiple WARNING: casting value returned by memory allocation > > function to (u_int32_t __user *) is useless. > > > > Remove unnecessary cast. > > > > Signed-off-by: Tobin C. Harding <me@tobin.cc> > > __user annotation requires the explicit cast. Ok, thanks for reviewing. Tobin. > > > Takashi > > > > --- > > sound/pci/emu10k1/emufx.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c > > index 56fc47b..8a39a6f 100644 > > --- a/sound/pci/emu10k1/emufx.c > > +++ b/sound/pci/emu10k1/emufx.c > > @@ -1186,8 +1186,8 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu) > > if (!icode) > > return err; > > > > - icode->gpr_map = (u_int32_t __user *) kcalloc(512 + 256 + 256 + 2 * 1024, > > - sizeof(u_int32_t), GFP_KERNEL); > > + icode->gpr_map = kcalloc(512 + 256 + 256 + 2 * 1024, > > + sizeof(u_int32_t), GFP_KERNEL); > > if (!icode->gpr_map) > > goto __err_gpr; > > controls = kcalloc(SND_EMU10K1_GPR_CONTROLS, > > @@ -1824,8 +1824,8 @@ static int _snd_emu10k1_init_efx(struct snd_emu10k1 *emu) > > if (!icode) > > return err; > > > > - icode->gpr_map = (u_int32_t __user *) kcalloc(256 + 160 + 160 + 2 * 512, > > - sizeof(u_int32_t), GFP_KERNEL); > > + icode->gpr_map = kcalloc(256 + 160 + 160 + 2 * 512, > > + sizeof(u_int32_t), GFP_KERNEL); > > if (!icode->gpr_map) > > goto __err_gpr; > > > > -- > > 2.7.4 > > > > -- Tobin Harding http://tobin.cc
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] ALSA: emu10k1: Remove cast from memory allocation "Tobin C. Harding" <me@tobin.cc> - 2017-02-22 07:50 +0100
Re: [PATCH] ALSA: emu10k1: Remove cast from memory allocation Takashi Iwai <tiwai@suse.de> - 2017-02-22 08:10 +0100
Re: [PATCH] ALSA: emu10k1: Remove cast from memory allocation "Tobin C. Harding" <me@tobin.cc> - 2017-02-22 11:40 +0100
csiph-web