Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582819

Re: [PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to bau_operations

Show all headers | View raw

On Tue, 14 Feb 2017, Andrew Banman wrote:

> Remove the present wait_completion routine and add a function pointer by
> the same name to the bau_operations struct. Rather than switching on the
> UV hub version during message processing, set the architecture-specific
> uv*_wait_completion during initialization.

Well written changelog!


> +static int uv1_wait_completion(struct bau_desc *bau_desc,
> +				struct bau_control *bcp, long try);
> +static int uv2_3_wait_completion(struct bau_desc *bau_desc,
> +				struct bau_control *bcp, long try);

You could spare the forward declarations by moving the uv*_bau_ops down
right before uv_bau_init(). And while at it, the uv*_bau_ops can be made
__initconst.

>  static struct bau_operations ops;

That one can be made __ro_after_init as the only possible modification
happens in the init function.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to bau_operations Andrew Banman <abanman@hpe.com> - 2017-02-15 03:00 +0100
  Re: [PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to  bau_operations Thomas Gleixner <tglx@linutronix.de> - 2017-02-16 19:20 +0100

csiph-web